| commit | 638d5bb8167c2c88552257d5af23f7f65ab4defd | |
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Sat, 15 Sep 2007 12:45:53 +0000 (15 14:45 +0200) | ||
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Tue, 16 Oct 2007 21:59:58 +0000 (16 23:59 +0200) | ||
| tree | 736f9e4fab8d5c086a889dadebe7d6d02f4bf0a5 | treesnapshot (tar.gz zip) |
| parent | 745647e7a2ae399f7f70aca47827e62c99c893b5 | commitdiff |
ieee1394: nodemgr: fix leak of struct csr1212_keyval
csr1212_keep_keyval(kv) in nodemgr_process_root_directory was
unbalanced if ne->vendor_name_kv already exists. This happens for
example if eth1394 or raw1394 modify the local config ROM and it is
parsed again.
As a bonus, the attempt to add the vendor_name_kv sysfs attribute
when it already exists is now fixed for good.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
csr1212_keep_keyval(kv) in nodemgr_process_root_directory was
unbalanced if ne->vendor_name_kv already exists. This happens for
example if eth1394 or raw1394 modify the local config ROM and it is
parsed again.
As a bonus, the attempt to add the vendor_name_kv sysfs attribute
when it already exists is now fixed for good.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
| drivers/ieee1394/nodemgr.c | diffblobblamehistory |