| commit | e576de82ee628f68e5a44527c7ee99eadeab2e62 | |
| author | Jesper Juhl <jesper.juhl@gmail.com> | |
| Fri, 10 Aug 2007 22:23:54 +0000 (10 15:23 -0700) | ||
| committer | David S. Miller <davem@sunset.davemloft.net> | |
| Tue, 14 Aug 2007 05:52:10 +0000 (13 22:52 -0700) | ||
| tree | 387900c511a4171568997f37e450238107746b6d | treesnapshot (tar.gz zip) |
| parent | d725fdc8027a4cd961f58d92917fbb91b171abfa | commitdiff |
[DCCP]: fix memory leak and clean up style - dccp_feat_empty_confirm()
There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm(). If we
hit the 'default:' case of the 'switch' statement, then we return without
freeing 'opt', thus leaking 'struct dccp_opt_pend' bytes.
The leak is fixed easily enough by adding a kfree(opt); before the return
statement.
The patch also changes the layout of the 'switch' to be more in line with
CodingStyle.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm(). If we
hit the 'default:' case of the 'switch' statement, then we return without
freeing 'opt', thus leaking 'struct dccp_opt_pend' bytes.
The leak is fixed easily enough by adding a kfree(opt); before the return
statement.
The patch also changes the layout of the 'switch' to be more in line with
CodingStyle.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/dccp/feat.c | diffblobblamehistory |