| commit | 73f20e58b1d586e9f6d3ddc3aad872829aca7743 | |
| author | Andrew Morton <akpm@linux-foundation.org> | |
| Mon, 28 Apr 2008 09:16:30 +0000 (28 02:16 -0700) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Mon, 28 Apr 2008 15:58:47 +0000 (28 08:58 -0700) | ||
| tree | cd426ad1186438a0b16ade918e73c0b84c4bbe92 | treesnapshot (tar.gz zip) |
| parent | c7a6c4edc74ee5c3d990325fe93b6916f43499f4 | commitdiff |
FAT_VALID_MEDIA(): remove pointless test
The on-disk media specification field in FAT is only 8-bits, so testing for
<=0xff is pointless, and can generate a "comparison is always true due to
limited range of data type" warning.
While we're there, convert FAT_VALID_MEDIA() into a C function - the present
implementation is buggy: it generates either one or two references to its
argument.
Cc: Frank Seidel <fseidel@suse.de>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
The on-disk media specification field in FAT is only 8-bits, so testing for
<=0xff is pointless, and can generate a "comparison is always true due to
limited range of data type" warning.
While we're there, convert FAT_VALID_MEDIA() into a C function - the present
implementation is buggy: it generates either one or two references to its
argument.
Cc: Frank Seidel <fseidel@suse.de>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| fs/fat/inode.c | diffblobblamehistory | |
| include/linux/msdos_fs.h | diffblobblamehistory |