esp_scsi: fix reset cleanup spinlock recursion
commit522939d45c293388e6a360210905f9230298df16
authorMaciej W. Rozycki <macro@linux-mips.org>
Mon, 10 Dec 2007 23:49:31 +0000 (10 15:49 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 11 Dec 2007 03:43:55 +0000 (10 19:43 -0800)
tree38c37c6688a5095ab49c8fd42425e2bf3fb61ae9
parent794e64d5e9c7f088378e093a48eb36a30091d82d
esp_scsi: fix reset cleanup spinlock recursion

The esp_reset_cleanup() function is called with the host lock held and
invokes starget_for_each_device() which wants to take it too.  Here is a
fix along the lines of shost_for_each_device()/__shost_for_each_device()
adding a __starget_for_each_device() counterpart which assumes the lock
has already been taken.

Eventually, I think the driver should get modified so that more work is
done as a softirq rather than in the interrupt context, but for now it
fixes a bug that causes the spinlock debugger to fire.

While at it, it fixes a small number of cosmetic problems with
starget_for_each_device() too.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/esp_scsi.c
drivers/scsi/scsi.c
include/scsi/scsi_device.h