| commit | b559292e066f6d570cd5aa5dbd41de61dd04bdce | |
| author | Philipp Reisner <philipp.reisner@linbit.com> | |
| Thu, 11 Jan 2007 09:58:10 +0000 (11 10:58 +0100) | ||
| committer | Mark Fasheh <mark.fasheh@oracle.com> | |
| Wed, 7 Feb 2007 20:15:58 +0000 (7 12:15 -0800) | ||
| tree | d8221b5f54ad9b8cef694de687013614dccf5966 | treesnapshot (tar.gz zip) |
| parent | 925037bcba7691db2403684141a276930ad184f3 | commitdiff |
[PATCH] ocfs2 heartbeat: clean up bio submission code
As was already pointed out Mathieu Avila on Thu, 07 Sep 2006 03:15:25 -0700
that OCFS2 is expecting bio_add_page() to add pages to BIOs in an easily
predictable manner.
That is not true, especially for devices with own merge_bvec_fn().
Therefore OCFS2's heartbeat code is very likely to fail on such devices.
Move the bio_put() call into the bio's bi_end_io() function. This makes the
whole idea of trying to predict the behaviour of bio_add_page() unnecessary.
Removed compute_max_sectors() and o2hb_compute_request_limits().
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
As was already pointed out Mathieu Avila on Thu, 07 Sep 2006 03:15:25 -0700
that OCFS2 is expecting bio_add_page() to add pages to BIOs in an easily
predictable manner.
That is not true, especially for devices with own merge_bvec_fn().
Therefore OCFS2's heartbeat code is very likely to fail on such devices.
Move the bio_put() call into the bio's bi_end_io() function. This makes the
whole idea of trying to predict the behaviour of bio_add_page() unnecessary.
Removed compute_max_sectors() and o2hb_compute_request_limits().
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
| fs/ocfs2/cluster/heartbeat.c | diffblobblamehistory |