| commit | 60aa49243d09afc873f082567d2e3c16634ced84 | |
| author | Jonathan Corbet <corbet@lwn.net> | |
| Sun, 1 Feb 2009 21:52:56 +0000 (1 14:52 -0700) | ||
| committer | Jonathan Corbet <corbet@lwn.net> | |
| Mon, 16 Mar 2009 14:34:35 +0000 (16 08:34 -0600) | ||
| tree | bb7c8d9668b35a3aa4e90d0a62500ac9d3e67f7f | treesnapshot (tar.gz zip) |
| parent | 76398425bb06b07cc3a3b1ce169c67dc9d6874ed | commitdiff |
Rationalize fasync return values
Most fasync implementations do something like:
return fasync_helper(...);
But fasync_helper() will return a positive value at times - a feature used
in at least one place. Thus, a number of other drivers do:
err = fasync_helper(...);
if (err < 0)
return err;
return 0;
In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Most fasync implementations do something like:
return fasync_helper(...);
But fasync_helper() will return a positive value at times - a feature used
in at least one place. Thus, a number of other drivers do:
err = fasync_helper(...);
if (err < 0)
return err;
return 0;
In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
17 files changed: