| commit | 52a2b11cafb1b14bacfc65a20966da5ba3a863e1 | |
| author | Arjan van de Ven <arjan@linux.intel.com> | |
| Thu, 1 Oct 2009 22:48:40 +0000 (1 15:48 -0700) | ||
| committer | Len Brown <len.brown@intel.com> | |
| Wed, 28 Oct 2009 15:49:37 +0000 (28 11:49 -0400) | ||
| tree | 0400a7b6aecaac81bd9fa71fa30292120ee0840c | treesnapshot (tar.gz zip) |
| parent | 012abeea669ea49636cf952d13298bb68654146a | commitdiff |
ACPI: clean up video.c boundary checks and types
proc.c and video.c are a bit sloppy around types and style,
confusing gcc for a new feature that'll be in 2.6.33 and will
cause a warning on the current code.
This patch changes
if (foo + 1 > sizeof bar)
into
if (foo >= sizeof(bar))
which is more kernel-style.
it also changes a variable in proc.c to unsigned; it gets assigned
a value from an unsigned type, and is then only compared for > not
for negative, so using unsigned is just outright the right type
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
proc.c and video.c are a bit sloppy around types and style,
confusing gcc for a new feature that'll be in 2.6.33 and will
cause a warning on the current code.
This patch changes
if (foo + 1 > sizeof bar)
into
if (foo >= sizeof(bar))
which is more kernel-style.
it also changes a variable in proc.c to unsigned; it gets assigned
a value from an unsigned type, and is then only compared for > not
for negative, so using unsigned is just outright the right type
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
| drivers/acpi/proc.c | diffblobblamehistory | |
| drivers/acpi/video.c | diffblobblamehistory |