| commit | fadac4060c0456ce0a190ee581746ae8663f84e1 | |
| author | Gabriel Paubert <paubert@iram.es> | |
| Fri, 23 Mar 2007 19:03:52 +0000 (23 12:03 -0700) | ||
| committer | Jeff Garzik <jeff@garzik.org> | |
| Wed, 28 Mar 2007 06:18:51 +0000 (28 02:18 -0400) | ||
| tree | 2d8c5f910214dbb4e911c97ce0f5813f0f5d7ca6 | treesnapshot (tar.gz zip) |
| parent | 3ba4d093fe8a26f5f2da94411bf8732fa6e9da86 | commitdiff |
mv643xx_eth: Fix use of uninitialized port_num field
In this driver, the default ethernet address is first set by by calling
eth_port_uc_addr_get() which reads the relevant registers of the
corresponding port as initially set by firmware. However that function
used the port_num field accessed through the private area of net_dev
before it was set.
The result was that one board I have ended up with the unicast address
set to 00:00:00:00:00:00 (only port 1 is connected on this board). The
problem appeared after commit 84dd619e4dc3b0b1c40dafd98c90fd950bce7bc5.
This patch fixes the bug by setting mp->port_num prior to calling
eth_port_uc_get_addr().
Signed-off-by: Gabriel Paubert <paubert@iram.es>
Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
In this driver, the default ethernet address is first set by by calling
eth_port_uc_addr_get() which reads the relevant registers of the
corresponding port as initially set by firmware. However that function
used the port_num field accessed through the private area of net_dev
before it was set.
The result was that one board I have ended up with the unicast address
set to 00:00:00:00:00:00 (only port 1 is connected on this board). The
problem appeared after commit 84dd619e4dc3b0b1c40dafd98c90fd950bce7bc5.
This patch fixes the bug by setting mp->port_num prior to calling
eth_port_uc_get_addr().
Signed-off-by: Gabriel Paubert <paubert@iram.es>
Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| drivers/net/mv643xx_eth.c | diffblobblamehistory |