| commit | fab4e76373a614d3af624caedf18bee43fc6ca16 | |
| author | David S. Miller <davem@davemloft.net> | |
| Fri, 4 Sep 2009 04:34:39 +0000 (3 21:34 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 4 Sep 2009 04:34:39 +0000 (3 21:34 -0700) | ||
| tree | 9f9fc4922a60e1018009e65e9f72e7e51fb67fe1 | treesnapshot (tar.gz zip) |
| parent | a8fdf2b331b38d61fb5f11f3aec4a4f9fb2dedcb | commitdiff |
WAN: dscc4: Fix warning pointing out a bug.
Noticed by Stephen Rothwell:
Today's linux-next build (x86_64 allmodconfig gcc-4.4.0)
produced this warning:
drivers/net/wan/dscc4.c: In function 'dscc4_rx_skb':
drivers/net/wan/dscc4.c:670: warning: suggest parentheses around comparison in operand of '|'
which actually points out a bug, I think. It is doing
(x & (y | z)) != y | z
when it probably means
(x & (y | z)) != (y | z)
Introduced by commit 5de3fcab91b0e1809eec030355d15801daf25083
("WAN: bit and/or confusion").
Signed-off-by: David S. Miller <davem@davemloft.net>
Noticed by Stephen Rothwell:
Today's linux-next build (x86_64 allmodconfig gcc-4.4.0)
produced this warning:
drivers/net/wan/dscc4.c: In function 'dscc4_rx_skb':
drivers/net/wan/dscc4.c:670: warning: suggest parentheses around comparison in operand of '|'
which actually points out a bug, I think. It is doing
(x & (y | z)) != y | z
when it probably means
(x & (y | z)) != (y | z)
Introduced by commit 5de3fcab91b0e1809eec030355d15801daf25083
("WAN: bit and/or confusion").
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/wan/dscc4.c | diffblobblamehistory |