| commit | ef0657c49e0f93dcebc9b4719e4fe0b478411f60 | |
| author | Julia Lawall <julia@diku.dk> | |
| Tue, 7 Jul 2009 02:09:50 +0000 (6 19:09 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 7 Jul 2009 02:09:50 +0000 (6 19:09 -0700) | ||
| tree | 2831b4c65c9008ff66b821c47a032a3ca65f3ca3 | treesnapshot (tar.gz zip) |
| parent | 5dcc60b71886795965fd5029b5d9a9ba7b5a2c17 | commitdiff |
drivers/net/cs89x0.c: Avoid using magic number in set_dma_mode
The constant DMA_RX_MODE is defined to be 0x14 in the local include file
cs89x0.h. Since a constant with the same name is used elsewhere with
set_dma_mode, it seems likely that this constant could be used here.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@ expression E1; identifier I; constant int C; @@
(
set_dma_mode(E1,I,...)
|
*set_dma_mode(E1,C,...)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
The constant DMA_RX_MODE is defined to be 0x14 in the local include file
cs89x0.h. Since a constant with the same name is used elsewhere with
set_dma_mode, it seems likely that this constant could be used here.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@ expression E1; identifier I; constant int C; @@
(
set_dma_mode(E1,I,...)
|
*set_dma_mode(E1,C,...)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/cs89x0.c | diffblobblamehistory |