| commit | ecd6de3c88e8cbcad175b2eab48ba05c2014f7b6 | |
| author | Oleg Nesterov <oleg@redhat.com> | |
| Wed, 29 Apr 2009 14:02:24 +0000 (29 16:02 +0200) | ||
| committer | James Morris <jmorris@namei.org> | |
| Wed, 29 Apr 2009 23:08:48 +0000 (30 09:08 +1000) | ||
| tree | ab9257bbe3f3bc9379cf0d252110f9abffba7751 | treesnapshot (tar.gz zip) |
| parent | 3bcac0263f0b45e67a64034ebcb69eb9abb742f4 | commitdiff |
selinux: selinux_bprm_committed_creds() should wake up ->real_parent, not ->parent.
We shouldn't worry about the tracer if current is ptraced, exec() must not
succeed if the tracer has no rights to trace this task after cred changing.
But we should notify ->real_parent which is, well, real parent.
Also, we don't need _irq to take tasklist, and we don't need parent's
->siglock to wake_up_interruptible(real_parent->signal->wait_chldexit).
Since we hold tasklist, real_parent->signal must be stable. Otherwise
spin_lock(siglock) is not safe too and can't help anyway.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
We shouldn't worry about the tracer if current is ptraced, exec() must not
succeed if the tracer has no rights to trace this task after cred changing.
But we should notify ->real_parent which is, well, real parent.
Also, we don't need _irq to take tasklist, and we don't need parent's
->siglock to wake_up_interruptible(real_parent->signal->wait_chldexit).
Since we hold tasklist, real_parent->signal must be stable. Otherwise
spin_lock(siglock) is not safe too and can't help anyway.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
| security/selinux/hooks.c | diffblobblamehistory |