| commit | eb8d3c604fe7496323efb9a858bef84c489ca584 | |
| author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Wed, 10 Jun 2009 19:43:02 +0000 (10 12:43 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Sun, 12 Jul 2009 20:02:09 +0000 (12 13:02 -0700) | ||
| tree | fe47cc2d57f7a7e2ba7936b7a89bbd49caf5bb5c | treesnapshot (tar.gz zip) |
| parent | 81e4e1ba7ed4a1fdcf0e2ee944f1575010471464 | commitdiff |
devres: WARN() and return, don't crash on device_del() of uninitialized device
I just debugged an obscure crash caused by a device_del() of a all NULL'd
out struct device (in usb-serial) and found that a patch like this one would
have saved me time (in addition to improved chances of a bug report from
users hitting similar driver bugs).
[akpm@linux-foundation.org: cleanup]
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
I just debugged an obscure crash caused by a device_del() of a all NULL'd
out struct device (in usb-serial) and found that a patch like this one would
have saved me time (in addition to improved chances of a bug report from
users hitting similar driver bugs).
[akpm@linux-foundation.org: cleanup]
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/base/devres.c | diffblobblamehistory |