| commit | c9c1014b2bd014c7ec037bbb6f58818162fdb265 | |
| author | Patrick McHardy <kaber@trash.net> | |
| Thu, 24 Apr 2008 05:10:48 +0000 (23 22:10 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 24 Apr 2008 05:10:48 +0000 (23 22:10 -0700) | ||
| tree | deace0019cbe1600d94e0de85791faa5eb14358e | treesnapshot (tar.gz zip) |
| parent | 6440be177f56e0b52dd81df82b78875d9a07d5f9 | commitdiff |
[RTNETLINK]: Fix bogus ASSERT_RTNL warning
ASSERT_RTNL uses mutex_trylock to test whether the rtnl_mutex is
held. This bogus warnings when running in atomic context, which
f.e. happens when adding secondary unicast addresses through
macvlan or vlan or when synchronizing multicast addresses from
wireless devices.
Mid-term we might want to consider moving all address updates
to process context since the locking seems overly complicated,
for now just fix the bogus warning by changing ASSERT_RTNL to
use mutex_is_locked().
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
ASSERT_RTNL uses mutex_trylock to test whether the rtnl_mutex is
held. This bogus warnings when running in atomic context, which
f.e. happens when adding secondary unicast addresses through
macvlan or vlan or when synchronizing multicast addresses from
wireless devices.
Mid-term we might want to consider moving all address updates
to process context since the locking seems overly complicated,
for now just fix the bogus warning by changing ASSERT_RTNL to
use mutex_is_locked().
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| include/linux/rtnetlink.h | diffblobblamehistory | |
| net/core/rtnetlink.c | diffblobblamehistory |