mm_for_maps: take ->cred_guard_mutex to fix the race with exec
commitc6d59cb0341e2c3aed3eb65cbf166a686c3443aa
authorOleg Nesterov <oleg@redhat.com>
Fri, 10 Jul 2009 01:27:40 +0000 (10 03:27 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 16 Aug 2009 21:19:14 +0000 (16 14:19 -0700)
treee9d8f205f258516747544909774a59cfd441bd83
parent17dc3e97d6d51df33cb6e35fabb62b91ef14cf2c
mm_for_maps: take ->cred_guard_mutex to fix the race with exec

commit 704b836cbf19e885f8366bccb2e4b0474346c02d upstream.

The problem is minor, but without ->cred_guard_mutex held we can race
with exec() and get the new ->mm but check old creds.

Now we do not need to re-check task->mm after ptrace_may_access(), it
can't be changed to the new mm under us.

Strictly speaking, this also fixes another very minor problem. Unless
security check fails or the task exits mm_for_maps() should never
return NULL, the caller should get either old or new ->mm.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/proc/base.c