| commit | c4f283b1f275e5528c13c119e5cfc80cdba55d00 | |
| author | Jay Vosburgh <fubar@us.ibm.com> | |
| Thu, 1 Mar 2007 01:03:20 +0000 (28 17:03 -0800) | ||
| committer | Jeff Garzik <jeff@garzik.org> | |
| Tue, 6 Mar 2007 11:08:11 +0000 (6 06:08 -0500) | ||
| tree | 2d5b172fe18c84029619b3a5dca524a24f9c4e49 | treesnapshot (tar.gz zip) |
| parent | c3442e296517aee733d62fc3fe03211598902c7d | commitdiff |
bonding: fix double dev_add_pack
Bonding can erroneously register the same packet_type to receive
ARPs (for use by ARP validation): once at device open time, and once via
sysfs. Since sysfs can change the validate setting (and thus register
or unregister) at any time, a flag is needed to synchronize with device
open in order to avoid double registrations, and the simplest place is
within the packet_type structure itself. Double unregister is not an
issue.
Bug reported by Ulrich Oelmann <ulrich.oelmann@web.de>.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Bonding can erroneously register the same packet_type to receive
ARPs (for use by ARP validation): once at device open time, and once via
sysfs. Since sysfs can change the validate setting (and thus register
or unregister) at any time, a flag is needed to synchronize with device
open in order to avoid double registrations, and the simplest place is
within the packet_type structure itself. Double unregister is not an
issue.
Bug reported by Ulrich Oelmann <ulrich.oelmann@web.de>.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| drivers/net/bonding/bond_main.c | diffblobblamehistory |