USB: serial: don't call release without attach
commita4720c650b68a5fe7faed2edeb0ad12645f7ae63
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 9 Oct 2009 16:43:12 +0000 (9 12:43 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 9 Oct 2009 20:52:05 +0000 (9 13:52 -0700)
tree829c32036a25279bb9aa1fc6077af5fa52f8f29e
parentba6b702f85a61561d329c4c11d3ed95604924f9a
USB: serial: don't call release without attach

This patch (as1295) fixes a recently-added bug in the USB serial core.
If certain kinds of errors occur during probing, the core may call a
serial driver's release method without previously calling the attach
method.  This causes some drivers (io_ti in particular) to perform an
invalid memory access.

The patch adds a new flag to keep track of whether or not attach has
been called.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Jean-Denis Girard <jd.girard@sysnux.pf>
CC: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/usb-serial.c
include/linux/usb/serial.h