| commit | 99dadce8756bf08f5f8baf749533d044f6b3ff25 | |
| author | Rafael J. Wysocki <rjw@sisk.pl> | |
| Wed, 4 Feb 2009 00:59:09 +0000 (4 01:59 +0100) | ||
| committer | Jesse Barnes <jbarnes@virtuousgeek.org> | |
| Thu, 5 Feb 2009 01:21:08 +0000 (4 17:21 -0800) | ||
| tree | 7593c043681c463382fafb22737e4f4a7f52f00b | treesnapshot (tar.gz zip) |
| parent | 144a76bc885ef4852601c66595326e59f12877f8 | commitdiff |
PCI PM: Fix saving of device state in pci_legacy_suspend
Make pci_legacy_suspend() save the state of the device if it is
in PCI_UNKNOWN after its suspend callback has run and warn only if
the power state of the device has been changed by its suspend
callback.
Also, use WARN_ONCE(), which is more useful, in pci_legacy_suspend(),
so that the name of the offending function is printed.
Additionally, remove the unnecessary line of code setting
pci_dev->state_saved.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Make pci_legacy_suspend() save the state of the device if it is
in PCI_UNKNOWN after its suspend callback has run and warn only if
the power state of the device has been changed by its suspend
callback.
Also, use WARN_ONCE(), which is more useful, in pci_legacy_suspend(),
so that the name of the offending function is printed.
Additionally, remove the unnecessary line of code setting
pci_dev->state_saved.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
| drivers/pci/pci-driver.c | diffblobblamehistory |