| commit | 98934def70b48dac74fac3738b78ab2d1a28edda | |
| author | William Lee Irwin III <wli@holomorphy.com> | |
| Wed, 12 Dec 2007 11:56:55 +0000 (12 03:56 -0800) | ||
| committer | Len Brown <len.brown@intel.com> | |
| Thu, 13 Dec 2007 21:24:10 +0000 (13 16:24 -0500) | ||
| tree | 75d97b7fb0dc47f19ad2ef5521fe69036ddfac60 | treesnapshot (tar.gz zip) |
| parent | da8cadb31b82c9d41fc593c8deab6aa20b162d6b | commitdiff |
ACPI: video_device_list corruption
The ->cap fields of struct acpi_video_device and struct acpi_video_bus
are 1B each, not 4B. The oversized memset()'s corrupted the subsequent
list_head fields. This resulted in silent corruption without
CONFIG_DEBUG_LIST and BUG's with it. This patch uses sizeof() to pass
the proper bounds to the memset() calls and thereby correct the bugs.
Signed-off-by: William Irwin <wli@holomorphy.com>
Acked-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Len Brown <len.brown@intel.com>
The ->cap fields of struct acpi_video_device and struct acpi_video_bus
are 1B each, not 4B. The oversized memset()'s corrupted the subsequent
list_head fields. This resulted in silent corruption without
CONFIG_DEBUG_LIST and BUG's with it. This patch uses sizeof() to pass
the proper bounds to the memset() calls and thereby correct the bugs.
Signed-off-by: William Irwin <wli@holomorphy.com>
Acked-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Len Brown <len.brown@intel.com>
| drivers/acpi/video.c | diffblobblamehistory |