| commit | 967ab999a090b1a4e7d3c7febfd6d89b42fb4cf4 | |
| author | Pavel Emelyanov <xemul@openvz.org> | |
| Thu, 31 Jul 2008 07:38:52 +0000 (31 00:38 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 31 Jul 2008 07:38:52 +0000 (31 00:38 -0700) | ||
| tree | 7ccc98a3ef1be4ca3129de23b083ab2bc47eb5c3 | treesnapshot (tar.gz zip) |
| parent | a8ddc9163c6a16cd62531dba1ec5020484e33b02 | commitdiff |
netfilter: xt_hashlimit: fix race between htable_destroy and htable_gc
Deleting a timer with del_timer doesn't guarantee, that the
timer function is not running at the moment of deletion. Thus
in the xt_hashlimit case we can get into a ticklish situation
when the htable_gc rearms the timer back and we'll actually
delete an entry with a pending timer.
Fix it with using del_timer_sync().
AFAIK del_timer_sync checks for the timer to be pending by
itself, so I remove the check.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Deleting a timer with del_timer doesn't guarantee, that the
timer function is not running at the moment of deletion. Thus
in the xt_hashlimit case we can get into a ticklish situation
when the htable_gc rearms the timer back and we'll actually
delete an entry with a pending timer.
Fix it with using del_timer_sync().
AFAIK del_timer_sync checks for the timer to be pending by
itself, so I remove the check.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/netfilter/xt_hashlimit.c | diffblobblamehistory |