| commit | 9469d458b90bfb9117cbb488cfa645d94c3921b1 | |
| author | Sergey Vlasov <vsu@altlinux.ru> | |
| Mon, 10 Apr 2006 05:32:48 +0000 (9 22:32 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 10 Apr 2006 05:32:48 +0000 (9 22:32 -0700) | ||
| tree | 7b409ef16b310336edddcb396d1601896f39d33b | treesnapshot (tar.gz zip) |
| parent | 30aaa154fc21ad1ee4400e28009732a04a80862f | commitdiff |
[NET]: Fix hotplug race during device registration.
From: Thomas de Grenier de Latour <degrenier@easyconnect.fr>
On Sun, 9 Apr 2006 21:56:59 +0400,
Sergey Vlasov <vsu@altlinux.ru> wrote:
> However, show_address() does not output anything unless
> dev->reg_state == NETREG_REGISTERED - and this state is set by
> netdev_run_todo() only after netdev_register_sysfs() returns, so in
> the meantime (while netdev_register_sysfs() is busy adding the
> "statistics" attribute group) some process may see an empty "address"
> attribute.
I've tried the attached patch, suggested by Sergey Vlasov on
hotplug-devel@, and as far as i can test it works just fine.
Signed-off-by: David S. Miller <davem@davemloft.net>
From: Thomas de Grenier de Latour <degrenier@easyconnect.fr>
On Sun, 9 Apr 2006 21:56:59 +0400,
Sergey Vlasov <vsu@altlinux.ru> wrote:
> However, show_address() does not output anything unless
> dev->reg_state == NETREG_REGISTERED - and this state is set by
> netdev_run_todo() only after netdev_register_sysfs() returns, so in
> the meantime (while netdev_register_sysfs() is busy adding the
> "statistics" attribute group) some process may see an empty "address"
> attribute.
I've tried the attached patch, suggested by Sergey Vlasov on
hotplug-devel@, and as far as i can test it works just fine.
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/core/dev.c | diffblobblamehistory |