| commit | 8be78bc620adf972f6d33bc6202ba1b85fdd4db5 | |
| author | Peng Tao <bergwolf@gmail.com> | |
| Tue, 11 Aug 2009 03:05:28 +0000 (10 23:05 -0400) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 14 Dec 2009 16:06:06 +0000 (14 08:06 -0800) | ||
| tree | 7751534cf23d7586943578d02026c962bd869438 | treesnapshot (tar.gz zip) |
| parent | 65ccfef90fb74d4afd2414bc389a29f1a2dd94db | commitdiff |
ext4: fix journal ref count in move_extent_par_page
(cherry picked from commit 91cc219ad963731191247c5f2db4118be2bc341a)
move_extent_par_page calls a_ops->write_begin() to increase journal
handler's reference count. However, if either mext_replace_branches()
or ext4_get_block fails, the increased reference count isn't
decreased. This will cause a later attempt to umount of the fs to hang
forever. The patch addresses the issue by calling ext4_journal_stop()
if page is not NULL (which means a_ops->write_end() isn't invoked).
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
(cherry picked from commit 91cc219ad963731191247c5f2db4118be2bc341a)
move_extent_par_page calls a_ops->write_begin() to increase journal
handler's reference count. However, if either mext_replace_branches()
or ext4_get_block fails, the increased reference count isn't
decreased. This will cause a later attempt to umount of the fs to hang
forever. The patch addresses the issue by calling ext4_journal_stop()
if page is not NULL (which means a_ops->write_end() isn't invoked).
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| fs/ext4/move_extent.c | diffblobblamehistory |