| commit | 7ee8af9de5b806144734e2bfbbd9eccf5aecb374 | |
| author | Eric W. Biederman <ebiederm@xmission.com> | |
| Fri, 19 Feb 2010 13:22:59 +0000 (19 13:22 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 15 Mar 2010 15:49:38 +0000 (15 08:49 -0700) | ||
| tree | 2c6b3902787e5ce61a01cabe4140df3ef86244bc | treesnapshot (tar.gz zip) |
| parent | 26e272a3c2670bfbf91c477c964fc14d3e6f9ed5 | commitdiff |
net: Fix sysctl restarts...
[ Upstream commit 88af182e389097997c5e2a0b42285b3522796759 ]
Yuck. It turns out that when we restart sysctls we were restarting
with the values already changed. Which unfortunately meant that
the second time through we thought there was no change and skipped
all kinds of work, despite the fact that there was indeed a change.
I have fixed this the simplest way possible by restoring the changed
values when we restart the sysctl write.
One of my coworkers spotted this bug when after disabling forwarding
on an interface pings were still forwarded.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
[ Upstream commit 88af182e389097997c5e2a0b42285b3522796759 ]
Yuck. It turns out that when we restart sysctls we were restarting
with the values already changed. Which unfortunately meant that
the second time through we thought there was no change and skipped
all kinds of work, despite the fact that there was indeed a change.
I have fixed this the simplest way possible by restoring the changed
values when we restart the sysctl write.
One of my coworkers spotted this bug when after disabling forwarding
on an interface pings were still forwarded.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| net/ipv4/devinet.c | diffblobblamehistory | |
| net/ipv6/addrconf.c | diffblobblamehistory |