| commit | 73f38fe1b563a9d23ffacbda7b51decf41b0c49c | |
| author | Julia Lawall <julia@diku.dk> | |
| Mon, 23 Jun 2008 18:14:52 +0000 (24 04:14 +1000) | ||
| committer | Paul Mackerras <paulus@samba.org> | |
| Tue, 1 Jul 2008 01:28:17 +0000 (1 11:28 +1000) | ||
| tree | 37e228071b05696350bc015f26a5a9270dde927f | treesnapshot (tar.gz zip) |
| parent | 178f8d78fdeaace8b22a759a059b74f39caf23a4 | commitdiff |
drivers/macintosh/smu.c: Improve error handling
This makes two changes:
* As noted by Akinobu Mita in patch
b1fceac2b9e04d278316b2faddf276015fc06e3b, alloc_bootmem never returns NULL
and always returns a zeroed region of memory. Thus the error checking code
and memset after the call to alloc_bootmem are not necessary.
* The old error handling code consisted of setting a global variable to
NULL and returning an error code, which could cause previously allocated
resources never to be freed. The patch adds calls to appropriate resource
deallocation functions.
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This makes two changes:
* As noted by Akinobu Mita in patch
b1fceac2b9e04d278316b2faddf276015fc06e3b, alloc_bootmem never returns NULL
and always returns a zeroed region of memory. Thus the error checking code
and memset after the call to alloc_bootmem are not necessary.
* The old error handling code consisted of setting a global variable to
NULL and returning an error code, which could cause previously allocated
resources never to be freed. The patch adds calls to appropriate resource
deallocation functions.
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mackerras <paulus@samba.org>
| drivers/macintosh/smu.c | diffblobblamehistory |