| commit | 6d329af9967e7ab3f4a3d7f1e8ef87539c3a069f | |
| author | Roland Dreier <rdreier@cisco.com> | |
| Fri, 17 Oct 2008 21:18:26 +0000 (17 14:18 -0700) | ||
| committer | Jeff Garzik <jgarzik@redhat.com> | |
| Wed, 22 Oct 2008 10:22:14 +0000 (22 06:22 -0400) | ||
| tree | 526727c49e03164db570b5652a7ce6702c2138a5 | treesnapshot (tar.gz zip) |
| parent | d766a4eda65b80afb50a39ce15c0ca424115bc07 | commitdiff |
cxgb3: Fix kernel crash caused by uninitialized l2t_entry.arpq
Commit 147e70e6 ("cxgb3: Use SKB list interfaces instead of home-grown
implementation.") causes a crash in t3_l2t_send_slow() when an iWARP
connection request is received. This is because the new l2t_entry.arpq
skb queue is never initialized, and therefore trying to add an skb to
it causes a NULL dereference. With the old code there was no need to
initialize the queues because the l2t_entry structures were zeroed,
and the code used NULL to mean empty.
Fix this by adding __skb_queue_head_init() when all the l2t_entry
structures get allocated.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Commit 147e70e6 ("cxgb3: Use SKB list interfaces instead of home-grown
implementation.") causes a crash in t3_l2t_send_slow() when an iWARP
connection request is received. This is because the new l2t_entry.arpq
skb queue is never initialized, and therefore trying to add an skb to
it causes a NULL dereference. With the old code there was no need to
initialize the queues because the l2t_entry structures were zeroed,
and the code used NULL to mean empty.
Fix this by adding __skb_queue_head_init() when all the l2t_entry
structures get allocated.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| drivers/net/cxgb3/l2t.c | diffblobblamehistory |