| commit | 463889e27e6f4f097374a6c9de5611f520766dad | |
| author | Julia Lawall <julia@diku.dk> | |
| Mon, 27 Jul 2009 06:13:30 +0000 (27 06:13 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 27 Jul 2009 18:35:28 +0000 (27 11:35 -0700) | ||
| tree | 80c5d38c591e85fe004b571c84414d5603726b02 | treesnapshot (tar.gz zip) |
| parent | f004ec728bff3cf924ffc19387baca503cd73b01 | commitdiff |
drivers/net: Correct redundant test
res has already been tested. It seems that this test should be on the
recently returned value mmio.
A simplified version of the semantic match that finds this problem is as
follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
expression E;
@@
if (x == NULL || ...) { ... when forall
return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
*x == NULL
|
*x != NULL
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
res has already been tested. It seems that this test should be on the
recently returned value mmio.
A simplified version of the semantic match that finds this problem is as
follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
expression E;
@@
if (x == NULL || ...) { ... when forall
return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
*x == NULL
|
*x != NULL
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethoc.c | diffblobblamehistory |