| commit | 45223fd77c2b39d05dd7f1aaabf614abb1770bbe | |
| author | Eric Sesterhenn <snakebyte@gmx.de> | |
| Mon, 25 Sep 2006 23:59:08 +0000 (25 16:59 -0700) | ||
| committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | |
| Tue, 26 Sep 2006 18:35:28 +0000 (26 11:35 -0700) | ||
| tree | dd3f866f1d5c206a29d4aea31e687a2fe9bb1fd2 | treesnapshot (tar.gz zip) |
| parent | 53aefd3fc31f08487f6941282ef6611413e02e43 | commitdiff |
[SCSI] Signdness issue in drivers/scsi/osst.c
another signdness warning from gcc 4.1
drivers/scsi/osst.c:5154: warning: comparison of unsigned expression < 0 is always false
The problem is that blk is defined as unsigned, but all usages of it are
normal int cases. osst_get_frame_position() and osst_get_sector() return ints
and can return negative values. If blk stays an unsigned int, the error check
is useless.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
another signdness warning from gcc 4.1
drivers/scsi/osst.c:5154: warning: comparison of unsigned expression < 0 is always false
The problem is that blk is defined as unsigned, but all usages of it are
normal int cases. osst_get_frame_position() and osst_get_sector() return ints
and can return negative values. If blk stays an unsigned int, the error check
is useless.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| drivers/scsi/osst.c | diffblobblamehistory |