| commit | 4352d82647f679fb8dd9440b34400fa49beedb2c | |
| author | Olof Johansson <olof@lixom.net> | |
| Tue, 4 Dec 2007 03:34:14 +0000 (3 21:34 -0600) | ||
| committer | Jeff Garzik <jeff@garzik.org> | |
| Tue, 4 Dec 2007 19:53:49 +0000 (4 14:53 -0500) | ||
| tree | 667455cf1c3fa8c3085c93bbf3e0755b6fb28fe6 | treesnapshot (tar.gz zip) |
| parent | d30f53aeb31d453a5230f526bea592af07944564 | commitdiff |
pasemi_mac: Fix reuse of free'd skb
Turns out we're freeing the skb when we detect CRC error, but we're
not clearing out info->skb. We could either clear it and have the stack
reallocate it, or just leave it and the rx ring refill code will reuse
the one that was allocated.
Reusing a freed skb obviously caused some nasty crashes of various kind,
as reported by Brent Baude and David Woodhouse.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Turns out we're freeing the skb when we detect CRC error, but we're
not clearing out info->skb. We could either clear it and have the stack
reallocate it, or just leave it and the rx ring refill code will reuse
the one that was allocated.
Reusing a freed skb obviously caused some nasty crashes of various kind,
as reported by Brent Baude and David Woodhouse.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| drivers/net/pasemi_mac.c | diffblobblamehistory |