| commit | 2543331d367c9fe54f4ba73300894bc21e0a08f4 | |
| author | Jay Vosburgh <fubar@us.ibm.com> | |
| Fri, 18 Jan 2008 00:24:59 +0000 (17 16:24 -0800) | ||
| committer | Jeff Garzik <jeff@garzik.org> | |
| Fri, 18 Jan 2008 19:38:38 +0000 (18 14:38 -0500) | ||
| tree | 83c43c448b7f18541dbe70ca4ff80138f8e695d4 | treesnapshot (tar.gz zip) |
| parent | e0138a66e18c6755ee29ce13b3f1142af775dc5f | commitdiff |
bonding: fix locking during alb failover and slave removal
alb_fasten_mac_swap (actually rlb_teach_disabled_mac_on_primary)
requries RTNL and no other locks. This could cause dev_set_promiscuity
and/or dev_set_mac_address to be called with improper locking.
Changed callers to hold only RTNL during calls to alb_fasten_mac_swap
or functions calling it. Updated header comments in affected functions to
reflect proper reality of locking requirements.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
alb_fasten_mac_swap (actually rlb_teach_disabled_mac_on_primary)
requries RTNL and no other locks. This could cause dev_set_promiscuity
and/or dev_set_mac_address to be called with improper locking.
Changed callers to hold only RTNL during calls to alb_fasten_mac_swap
or functions calling it. Updated header comments in affected functions to
reflect proper reality of locking requirements.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| drivers/net/bonding/bond_alb.c | diffblobblamehistory | |
| drivers/net/bonding/bond_main.c | diffblobblamehistory |