| commit | 239795adf7f1a40cf0be0e05544d37706c9b4cf9 | |
| author | Ben Hutchings <bhutchings@solarflare.com> | |
| Wed, 15 Apr 2009 02:48:34 +0000 (14 19:48 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Wed, 15 Apr 2009 02:48:34 +0000 (14 19:48 -0700) | ||
| tree | bdf142e6e9a4c610f56f51b2d4842959c611fded | treesnapshot (tar.gz zip) |
| parent | 718cff1eec595ce6ab0635b8160a51ee37d9268d | commitdiff |
sfc: Use correct macro to set event bitfield
falcon_sim_phy_event() used EFX_OWORD_FIELD, which operates on
bitfields in 128-bit values, on an event, which is a 64-bit value.
This should be harmless - these macros always use little-endian
ordering, so it would read and write back the following 8 bytes
unchanged - but it is obviously wrong.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
falcon_sim_phy_event() used EFX_OWORD_FIELD, which operates on
bitfields in 128-bit values, on an event, which is a 64-bit value.
This should be harmless - these macros always use little-endian
ordering, so it would read and write back the following 8 bytes
unchanged - but it is obviously wrong.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/sfc/falcon.c | diffblobblamehistory |