| commit | 21e2b0a5efb3a01de58e7cb630f2eb70894da352 | |
| author | Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> | |
| Thu, 8 May 2008 05:37:25 +0000 (8 14:37 +0900) | ||
| committer | Jesse Barnes <jbarnes@virtuousgeek.org> | |
| Tue, 13 May 2008 16:51:53 +0000 (13 09:51 -0700) | ||
| tree | 7bf83b7fa2de1c10defdbcac59bf626ffbb87fcd | treesnapshot (tar.gz zip) |
| parent | c714a534d85576af21b06be605ca55cb2fb887ee | commitdiff |
PCI ACPI: fix uninitialized variable in __pci_osc_support_set
Fix uninitialized variable in __pci_osc_support_set().
If the ACPI namespace doesn't have any device object corresponding to
the specified hid, 'retval' in __pci_osc_support_set() is not changed
by the acpi_query_osc() callback. Since 'retval' is not initizlized in
the current implementation, the contents of 'retval' is undefined in
this case. This causes a mis-handling of ctrlset_buf[OSC_SUPPORT_TYPE]
and will cause an unexpected result in the subsequent
pci_osc_control_set() call as a result.
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Fix uninitialized variable in __pci_osc_support_set().
If the ACPI namespace doesn't have any device object corresponding to
the specified hid, 'retval' in __pci_osc_support_set() is not changed
by the acpi_query_osc() callback. Since 'retval' is not initizlized in
the current implementation, the contents of 'retval' is undefined in
this case. This causes a mis-handling of ctrlset_buf[OSC_SUPPORT_TYPE]
and will cause an unexpected result in the subsequent
pci_osc_control_set() call as a result.
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
| drivers/pci/pci-acpi.c | diffblobblamehistory |