| commit | 0e7830b50b20fcc25f21f79b7734102284d7c8f9 | |
| author | Mauro Carvalho Chehab <mchehab@infradead.org> | |
| Sat, 14 Jun 2008 14:27:34 +0000 (14 11:27 -0300) | ||
| committer | Mauro Carvalho Chehab <mchehab@infradead.org> | |
| Thu, 26 Jun 2008 18:58:48 +0000 (26 15:58 -0300) | ||
| tree | 9d043cd20dd680a07202001e9949e6bced7bfeb7 | treesnapshot (tar.gz zip) |
| parent | bc36ec746409e4e4719b94a86dc0d8cbeb6f439f | commitdiff |
V4L/DVB (8029): Improve error message at tda1004x_attach
When an error occurs at firmware loading, sometimes, tda1004x stops answering.
Instead of reporting such error, attach code were assuming that the device were
answering an invalid ID (0xff). This can be seen when enabling debug options:
tda1004x: tda1004x_read_byte: reg=0x0
tda1004x: tda1004x_read_byte: error reg=0x0, ret=-5
Now, instead of reporting an invalid ID, it will report the correct error:
tda10046: chip is not answering. Giving up.
saa7133[0]/dvb: failed to attach tda10046
saa7133[0]/dvb: frontend initialization failed
A possible improvement would be trying to reset the device.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
When an error occurs at firmware loading, sometimes, tda1004x stops answering.
Instead of reporting such error, attach code were assuming that the device were
answering an invalid ID (0xff). This can be seen when enabling debug options:
tda1004x: tda1004x_read_byte: reg=0x0
tda1004x: tda1004x_read_byte: error reg=0x0, ret=-5
Now, instead of reporting an invalid ID, it will report the correct error:
tda10046: chip is not answering. Giving up.
saa7133[0]/dvb: failed to attach tda10046
saa7133[0]/dvb: frontend initialization failed
A possible improvement would be trying to reset the device.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
| drivers/media/dvb/frontends/tda1004x.c | diffblobblamehistory |