| commit | 0706efd61edfcf958c2c19669aa65c2180ec3ba0 | |
| author | Tejun Heo <htejun@gmail.com> | |
| Mon, 19 Nov 2007 09:06:11 +0000 (19 18:06 +0900) | ||
| committer | Jeff Garzik <jeff@garzik.org> | |
| Sat, 24 Nov 2007 00:23:55 +0000 (23 19:23 -0500) | ||
| tree | 9accc045719661b364158cd1c3ca51bcad035678 | treesnapshot (tar.gz zip) |
| parent | dd05c199cd02ffd2ac49eb29677f1468910996a8 | commitdiff |
pata_jmicron: fix disabled port handling in jmicron_pre_reset()
There are two bugs in disabled port handling.
* test in PORT_PATA0 is reversed
* ->prereset should return -ENOENT for disabled ports not 0
The first bug makes the PATA channel considered disabled but the
second bug saves the day by returning 0. The net result is that cable
is always left at ATA_CBL_UNKNOWN. This results in false 80c
configuration and thus transfer errors.
This patch fixes both bugs.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
There are two bugs in disabled port handling.
* test in PORT_PATA0 is reversed
* ->prereset should return -ENOENT for disabled ports not 0
The first bug makes the PATA channel considered disabled but the
second bug saves the day by returning 0. The net result is that cable
is always left at ATA_CBL_UNKNOWN. This results in false 80c
configuration and thus transfer errors.
This patch fixes both bugs.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| drivers/ata/pata_jmicron.c | diffblobblamehistory |