| commit | 30e931d4092713cecd6b8c2fd70f268efaa6e428 | |
| author | Eric W. Biederman <ebiederm@xmission.com> | |
| Thu, 23 Mar 2006 10:59:35 +0000 (23 02:59 -0800) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Thu, 23 Mar 2006 15:38:04 +0000 (23 07:38 -0800) | ||
| tree | e7425d6e23720399d4f1a3078e63e03d62ca1d63 | treesnapshot (tar.gz zip) |
| parent | 4f88651125e2ca8b106b6f65b65ea45776517bf3 | commitdiff |
[PATCH] i386: Add a temporary to make put_user more type safe
In some code I am developing I had occasion to change the type of a
variable. This made the value put_user was putting to user space wrong.
But the code continued to build cleanly without errors.
Introducing a temporary fixes this problem and at least with gcc-3.3.5 does
not cause gcc any problems with optimizing out the temporary. gcc-4.x
using SSA internally ought to be even better at optimizing out temporaries,
so I don't expect a temporary to become a problem. Especially because in
all correct cases the types on both sides of the assignment to the
temporary are the same.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
In some code I am developing I had occasion to change the type of a
variable. This made the value put_user was putting to user space wrong.
But the code continued to build cleanly without errors.
Introducing a temporary fixes this problem and at least with gcc-3.3.5 does
not cause gcc any problems with optimizing out the temporary. gcc-4.x
using SSA internally ought to be even better at optimizing out temporaries,
so I don't expect a temporary to become a problem. Especially because in
all correct cases the types on both sides of the assignment to the
temporary are the same.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| include/asm-i386/uaccess.h | diffblobblamehistory |