Sanitize the type of struct user.u_ar0
commit6e16d89bcd668a95eb22add24c02d80890232b66
authorH. Peter Anvin <hpa@zytor.com>
Thu, 7 Feb 2008 08:15:57 +0000 (7 00:15 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 7 Feb 2008 16:42:30 +0000 (7 08:42 -0800)
tree8d5fcab14edac7d36c67e8a57abb5025cfaa2c2d
parented7b1889da256977574663689b598d88950bbd23
Sanitize the type of struct user.u_ar0

struct user.u_ar0 is defined to contain a pointer offset on all
architectures in which it is defined (all architectures which define an
a.out format except SPARC.) However, it has a pointer type in the headers,
which is pointless -- <asm/user.h> is not exported to userspace, and it
just makes the code messy.

Redefine the field as "unsigned long" (which is the same size as a pointer
on all Linux architectures) and change the setting code to user offsetof()
instead of hand-coded arithmetic.

Cc: Linux Arch Mailing List <linux-arch@vger.kernel.org>
Cc: Bryan Wu <bryan.wu@analog.com>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Lennert Buytenhek <kernel@wantstofly.org>
Cc: HÃ¥vard Skinnemoen <hskinnemoen@atmel.com>
Cc: Mikael Starvik <starvik@axis.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Hirokazu Takata <takata@linux-m32r.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
18 files changed:
arch/x86/ia32/ia32_aout.c
fs/binfmt_aout.c
include/asm-alpha/user.h
include/asm-arm/user.h
include/asm-avr32/user.h
include/asm-blackfin/user.h
include/asm-cris/user.h
include/asm-h8300/user.h
include/asm-ia64/user.h
include/asm-m32r/user.h
include/asm-m68k/user.h
include/asm-mips/user.h
include/asm-powerpc/user.h
include/asm-s390/user.h
include/asm-sh/user.h
include/asm-v850/user.h
include/asm-x86/user_32.h
include/asm-x86/user_64.h