| commit | 9c60debd2a666dc0e8466dee556af30ea68e97d2 | |
| author | Eric Miao <eric.miao@marvell.com> | |
| Thu, 31 Jan 2008 05:59:15 +0000 (31 00:59 -0500) | ||
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | |
| Thu, 31 Jan 2008 05:59:15 +0000 (31 00:59 -0500) | ||
| tree | 99aec1bfa7767beb981b75175abbfe1ec715197e | treesnapshot (tar.gz zip) |
| parent | 62059d9e912717abbfb875440621d935d091f289 | commitdiff |
Input: pxa27x_keypad - use device resources for I/O memory mapping and IRQ
1. use ioremap() for registers access, this improves the portability
of the driver (e.g. same IP on different processor with different
I/O memory range), and make it possible to remove those registers
definition in pxa-regs.h as PXA is undergoing a clean-up of that
header file
2. use device specific IRQ instead of hardcoded IRQ_KEYPAD, same
reason as above
3. clean up the error handling path in _probe()
4. remove DRIVER_NAME and use pdev->name when necessary, we don't
actually need a constant string literals
Signed-off-by: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
1. use ioremap() for registers access, this improves the portability
of the driver (e.g. same IP on different processor with different
I/O memory range), and make it possible to remove those registers
definition in pxa-regs.h as PXA is undergoing a clean-up of that
header file
2. use device specific IRQ instead of hardcoded IRQ_KEYPAD, same
reason as above
3. clean up the error handling path in _probe()
4. remove DRIVER_NAME and use pdev->name when necessary, we don't
actually need a constant string literals
Signed-off-by: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
| drivers/input/keyboard/pxa27x_keypad.c | diffblobblamehistory |