| commit | c5d712433ff57a66d8fb79a57a4fc7a7c3467b97 | |
| author | Rafael J. Wysocki <rjw@sisk.pl> | |
| Sat, 8 Nov 2008 12:53:33 +0000 (8 13:53 +0100) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Sat, 8 Nov 2008 18:02:48 +0000 (8 10:02 -0800) | ||
| tree | 35e98dc51e781bb24ef6a9bb7911d0cabef4c177 | treesnapshot (tar.gz zip) |
| parent | fed4d59b6ec5481caceb17863f19a0b0e5eaa939 | commitdiff |
Fix __pfn_to_page(pfn) for CONFIG_DISCONTIGMEM=y
Fix the __pfn_to_page(pfn) macro so that it doesn't evaluate its
argument twice in the CONFIG_DISCONTIGMEM=y case, because 'pfn' may
be a result of a funtion call having side effects.
For example, the hibernation code applies pfn_to_page(pfn) to the
result of a function returning the pfn corresponding to the next set
bit in a bitmap and the current bit position is modified on each
call. This leads to "interesting" failures for CONFIG_DISCONTIGMEM=y
due to the current behavior of __pfn_to_page(pfn).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Fix the __pfn_to_page(pfn) macro so that it doesn't evaluate its
argument twice in the CONFIG_DISCONTIGMEM=y case, because 'pfn' may
be a result of a funtion call having side effects.
For example, the hibernation code applies pfn_to_page(pfn) to the
result of a function returning the pfn corresponding to the next set
bit in a bitmap and the current bit position is modified on each
call. This leads to "interesting" failures for CONFIG_DISCONTIGMEM=y
due to the current behavior of __pfn_to_page(pfn).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| include/asm-generic/memory_model.h | diffblobblamehistory |