x86: Increase MIN_GAP to include randomized stack
commitfc5c8874e71764e58f4aaa11223c9cf62d9028ec
authorMichal Hocko <mhocko@suse.cz>
Tue, 8 Sep 2009 09:01:55 +0000 (8 11:01 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Oct 2009 16:31:28 +0000 (5 09:31 -0700)
tree361c0582760394f0b4534550639abb9c8bf4e107
parent511424ee51d395991c2e4bf608ce6b8c54b18675
x86: Increase MIN_GAP to include randomized stack

commit 80938332d8cf652f6b16e0788cf0ca136befe0b5 upstream.

Currently we are not including randomized stack size when calculating
mmap_base address in arch_pick_mmap_layout for topdown case. This might
cause that mmap_base starts in the stack reserved area because stack is
randomized by 1GB for 64b (8MB for 32b) and the minimum gap is 128MB.

If the stack really grows down to mmap_base then we can get silent mmap
region overwrite by the stack values.

Let's include maximum stack randomization size into MIN_GAP which is
used as the low bound for the gap in mmap.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
LKML-Reference: <1252400515-6866-1-git-send-email-mhocko@suse.cz>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/include/asm/elf.h
arch/x86/mm/mmap.c