| commit | f774f57a79ba1515eda139023cdc00b7209ab96b | |
| author | Neil Brown <neilb@suse.de> | |
| Fri, 26 Feb 2010 22:33:40 +0000 (27 09:33 +1100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 15 Mar 2010 16:07:01 +0000 (15 09:07 -0700) | ||
| tree | b6742aaccb2cc4d97d4d5d21d69c4f406a928e83 | treesnapshot (tar.gz zip) |
| parent | 293ad927682715d8f2bbe8350821b2b0d244f7eb | commitdiff |
sunrpc: remove unnecessary svc_xprt_put
commit ab1b18f70a007ea6caeb007d269abb75b131a410 upstream.
The 'struct svc_deferred_req's on the xpt_deferred queue do not
own a reference to the owning xprt. This is seen in svc_revisit
which is where things are added to this queue. dr->xprt is set to
NULL and the reference to the xprt it put.
So when this list is cleaned up in svc_delete_xprt, we mustn't
put the reference.
Also, replace the 'for' with a 'while' which is arguably
simpler and more likely to compile efficiently.
Cc: Tom Tucker <tom@opengridcomputing.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit ab1b18f70a007ea6caeb007d269abb75b131a410 upstream.
The 'struct svc_deferred_req's on the xpt_deferred queue do not
own a reference to the owning xprt. This is seen in svc_revisit
which is where things are added to this queue. dr->xprt is set to
NULL and the reference to the xprt it put.
So when this list is cleaned up in svc_delete_xprt, we mustn't
put the reference.
Also, replace the 'for' with a 'while' which is arguably
simpler and more likely to compile efficiently.
Cc: Tom Tucker <tom@opengridcomputing.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| net/sunrpc/svc_xprt.c | diffblobblamehistory |