| commit | ec668dbad7f732767d5484e1c7b317c767777f27 | |
| author | Jiri Pirko <jpirko@redhat.com> | |
| Tue, 11 Oct 2011 23:00:41 +0000 (11 23:00 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Fri, 11 Nov 2011 17:36:28 +0000 (11 09:36 -0800) | ||
| tree | 56e432298a62720a42075306a47d3140708ef520 | treesnapshot (tar.gz zip) |
| parent | b00654416d4baccf2269ec888e55d6df069cd36f | commitdiff |
tg3: negate USE_PHYLIB flag check
[ Upstream commit e730c82347b9dc75914da998c44c3f348965db41 ]
USE_PHYLIB flag in tg3_remove_one() is being checked incorrectly. This
results tg3_phy_fini->phy_disconnect is never called and when tg3 module
is removed.
In my case this resulted in panics in phy_state_machine calling function
phydev->adjust_link.
So correct this check.
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Acked-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
[ Upstream commit e730c82347b9dc75914da998c44c3f348965db41 ]
USE_PHYLIB flag in tg3_remove_one() is being checked incorrectly. This
results tg3_phy_fini->phy_disconnect is never called and when tg3 module
is removed.
In my case this resulted in panics in phy_state_machine calling function
phydev->adjust_link.
So correct this check.
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Acked-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/net/tg3.c | diffblobblamehistory |