SCSI: libiscsi: regression: fix header digest errors
commitec5e50f079ac7a22facdc1f535a755dab30a0af5
authorMike Christie <michaelc@cs.wisc.edu>
Sat, 24 Apr 2010 21:21:19 +0000 (24 16:21 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 May 2010 21:57:16 +0000 (12 14:57 -0700)
tree7d32514b5f3845b696cbfdb49e31f04b6f8b4833
parenta414b72407d6729915dc1af4c21f1c40d328d7da
SCSI: libiscsi: regression: fix header digest errors

commit 96b1f96dcab87756c0a1e7ba76bc5dc2add82b88 upstream.

This fixes a regression introduced with this commit:

commit d3305f3407fa3e9452079ec6cc8379067456e4aa
Author: Mike Christie <michaelc@cs.wisc.edu>
Date:   Thu Aug 20 15:10:58 2009 -0500

    [SCSI] libiscsi: don't increment cmdsn if cmd is not sent

in 2.6.32.

When I moved the hdr->cmdsn after init_task, I added
a bug when header digests are used. The problem is
that the LLD may calculate the header digest in init_task,
so if we then set the cmdsn after the init_task call we
change what the digest will be calculated by the target.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/libiscsi.c