| commit | eb5b35a560510efc6bb62f05c3c82e9596cdfafe | |
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Wed, 7 Jul 2010 12:13:14 +0000 (7 14:13 +0200) | ||
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Tue, 13 Jul 2010 07:47:47 +0000 (13 09:47 +0200) | ||
| tree | 59d610352e8e0e60de0ce958149fb08dddf6ce82 | treesnapshot (tar.gz zip) |
| parent | 656b7afd40a9f2b0d6cf8ef1972681961b428558 | commitdiff |
firewire: core: ensure some userspace API constants match corresponding kernel API constants
The FW_ISO_ constants of the in-kernel API of firewire-core and
FW_CDEV_ISO_ constants of the userspace API of firewire-core have
nothing to do with each other --- except that the core-cdev.c
implementation relies on them having the same values.
Hence put some compile-time assertions into core-cdev.c. It's lame but
I prefer it over including the userspace API header into the kernelspace
API header and defining kernelspace API constants from userspace API
constants. Nor do I want to expose the kernelspace constants in one of
the two firewire headers that are exported to userland since this only
concerns the core-cdev.c implementation.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
The FW_ISO_ constants of the in-kernel API of firewire-core and
FW_CDEV_ISO_ constants of the userspace API of firewire-core have
nothing to do with each other --- except that the core-cdev.c
implementation relies on them having the same values.
Hence put some compile-time assertions into core-cdev.c. It's lame but
I prefer it over including the userspace API header into the kernelspace
API header and defining kernelspace API constants from userspace API
constants. Nor do I want to expose the kernelspace constants in one of
the two firewire headers that are exported to userland since this only
concerns the core-cdev.c implementation.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
| drivers/firewire/core-cdev.c | diffblobblamehistory |