| commit | eb3efa1249b6413be930bdf13d10b6238028a440 | |
| author | Dave Chinner <dchinner@redhat.com> | |
| Fri, 3 Dec 2010 05:42:57 +0000 (3 16:42 +1100) | ||
| committer | Dave Chinner <david@fromorbit.com> | |
| Fri, 3 Dec 2010 05:42:57 +0000 (3 16:42 +1100) | ||
| tree | 7b2d8b9d55d5757236ef90389bc6664784607930 | treesnapshot (tar.gz zip) |
| parent | b199c8a4ba11879df87daad496ceee41fdc6aa82 | commitdiff |
xfs: clean up xfs_ail_delete()
xfs_ail_delete() has a needlessly complex interface. It returns the log item
that was passed in for deletion (which the callers then assert is identical to
the one passed in), and callers of xfs_ail_delete() still need to invalidate
current traversal cursors.
Make xfs_ail_delete() return void, move the cursor invalidation inside it, and
clean up the callers just to use the log item pointer they passed in.
While cleaning up, remove the messy and unnecessary "/* ARGUSED */" comments
around all these functions.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
xfs_ail_delete() has a needlessly complex interface. It returns the log item
that was passed in for deletion (which the callers then assert is identical to
the one passed in), and callers of xfs_ail_delete() still need to invalidate
current traversal cursors.
Make xfs_ail_delete() return void, move the cursor invalidation inside it, and
clean up the callers just to use the log item pointer they passed in.
While cleaning up, remove the messy and unnecessary "/* ARGUSED */" comments
around all these functions.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
| fs/xfs/xfs_trans_ail.c | diffblobblamehistory |