rds: Integer overflow in RDS cmsg handling
commitead0b93a89eb1bab781b1812b42b3cffeecda1d0
authorDan Rosenberg <drosenberg@vsecurity.com>
Wed, 17 Nov 2010 06:37:16 +0000 (17 06:37 +0000)
committerAndi Kleen <ak@linux.intel.com>
Tue, 14 Dec 2010 22:40:18 +0000 (14 23:40 +0100)
treefe65896c4f6b4c9db5017f865f1ae9b123a3b28f
parent8bad5a9770496e333505c129225074f61898c514
rds: Integer overflow in RDS cmsg handling

commit 218854af84038d828a32f061858b1902ed2beec6 upstream.

In rds_cmsg_rdma_args(), the user-provided args->nr_local value is
restricted to less than UINT_MAX.  This seems to need a tighter upper
bound, since the calculation of total iov_size can overflow, resulting
in a small sock_kmalloc() allocation.  This would probably just result
in walking off the heap and crashing when calling rds_rdma_pages() with
a high count value.  If it somehow doesn't crash here, then memory
corruption could occur soon after.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
net/rds/rdma.c