| commit | e847cc832bab50aad939a0c30414cd986637564d | |
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Sat, 12 Jun 2010 18:29:07 +0000 (12 20:29 +0200) | ||
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Sat, 19 Jun 2010 11:01:40 +0000 (19 13:01 +0200) | ||
| tree | 35b5d7af3e3f3337b8f7c9c43029618bec3a1f69 | treesnapshot (tar.gz zip) |
| parent | 65b2742ac002f554f6ca0c2eab84cc62400eafdf | commitdiff |
firewire: drop sizeof expressions from some request size arguments
In case of fw_card_bm_work()'s lock request, the present sizeof
expression is going to be wrong if somebody changes the fw_card's DMA
scratch buffer's size in the future.
In case of quadlet write requests, sizeof(u32) is just silly; it's 4.
In case of SBP-2 ORB pointer write requests, 8 is arguably quicker to
understand as the correct and only possible value than
sizeof(some_datum).
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
In case of fw_card_bm_work()'s lock request, the present sizeof
expression is going to be wrong if somebody changes the fw_card's DMA
scratch buffer's size in the future.
In case of quadlet write requests, sizeof(u32) is just silly; it's 4.
In case of SBP-2 ORB pointer write requests, 8 is arguably quicker to
understand as the correct and only possible value than
sizeof(some_datum).
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
| drivers/firewire/core-card.c | diffblobblamehistory | |
| drivers/firewire/sbp2.c | diffblobblamehistory |