| commit | e31b71b96e2440fd0f664443d1b1ecdf57b0bf5a | |
| author | Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com> | |
| Sun, 28 Nov 2010 21:46:50 +0000 (28 19:46 -0200) | ||
| committer | Andi Kleen <ak@linux.intel.com> | |
| Tue, 14 Dec 2010 22:40:16 +0000 (14 23:40 +0100) | ||
| tree | 88b83d3756a4a125adc82aa18a907d7f70d0d70c | treesnapshot (tar.gz zip) |
| parent | f0ad38dade9e69ffefc37734b37e3bd93654a00f | commitdiff |
wmi: use memcmp instead of strncmp to compare GUIDs
commit 8b14d7b22c61f17ccb869e0047d9df6dd9f50a9f upstream.
While looking for the duplicates in /sys/class/wmi/, I couldn't find
them. The code that looks for duplicates uses strncmp in a binary GUID,
which may contain zero bytes. The right function is memcmp, which is
also used in another section of wmi code.
It was finding 49142400-C6A3-40FA-BADB-8A2652834100 as a duplicate of
39142400-C6A3-40FA-BADB-8A2652834100. Since the first byte is the fourth
printed, they were found as equal by strncmp.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
commit 8b14d7b22c61f17ccb869e0047d9df6dd9f50a9f upstream.
While looking for the duplicates in /sys/class/wmi/, I couldn't find
them. The code that looks for duplicates uses strncmp in a binary GUID,
which may contain zero bytes. The right function is memcmp, which is
also used in another section of wmi code.
It was finding 49142400-C6A3-40FA-BADB-8A2652834100 as a duplicate of
39142400-C6A3-40FA-BADB-8A2652834100. Since the first byte is the fourth
printed, they were found as equal by strncmp.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
| drivers/platform/x86/wmi.c | diffblobblamehistory |