| commit | e286d83959320fcf7eadfc81aeceb6e1a81667c9 | |
| author | Dan Rosenberg <drosenberg@vsecurity.com> | |
| Wed, 22 Sep 2010 20:05:09 +0000 (22 13:05 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 27 Sep 2010 00:21:27 +0000 (26 17:21 -0700) | ||
| tree | db2c29cfc3bf967966ccf91bd09b1352fe0b60c8 | treesnapshot (tar.gz zip) |
| parent | 0a71220bc6dc9ef745de3beb618f18c42af433db | commitdiff |
drivers/video/sis/sis_main.c: prevent reading uninitialized stack memory
commit fd02db9de73faebc51240619c7c7f99bee9f65c7 upstream.
The FBIOGET_VBLANK device ioctl allows unprivileged users to read 16 bytes
of uninitialized stack memory, because the "reserved" member of the
fb_vblank struct declared on the stack is not altered or zeroed before
being copied back to the user. This patch takes care of it.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit fd02db9de73faebc51240619c7c7f99bee9f65c7 upstream.
The FBIOGET_VBLANK device ioctl allows unprivileged users to read 16 bytes
of uninitialized stack memory, because the "reserved" member of the
fb_vblank struct declared on the stack is not altered or zeroed before
being copied back to the user. This patch takes care of it.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/video/sis/sis_main.c | diffblobblamehistory |