secmark: do not return early if there was no error
commite0b20e1140f0a2b691cffd28c7ac2a29d59b96ee
authorEric Paris <eparis@redhat.com>
Tue, 12 Oct 2010 15:40:08 +0000 (12 11:40 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 22 Nov 2010 19:00:17 +0000 (22 11:00 -0800)
tree8d972aabfed0bbd04f578a702c5a27a46bc71ed8
parentbadaad1d7392eebf646b2e2d4dfe2586e40a8f18
secmark: do not return early if there was no error

commit 15714f7b58011cf3948cab2988abea560240c74f upstream.

Commit 4a5a5c73 attempted to pass decent error messages back to userspace for
netfilter errors.  In xt_SECMARK.c however the patch screwed up and returned
on 0 (aka no error) early and didn't finish setting up secmark.  This results
in a kernel BUG if you use SECMARK.

Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: James Morris <jmorris@namei.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/netfilter/xt_SECMARK.c