| commit | da1ab3e233eb1ff4116b178006a89ddca7dcd928 | |
| author | Jesper Juhl <jj@chaosbits.net> | |
| Sun, 13 Feb 2011 10:49:32 +0000 (13 10:49 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 14 Feb 2011 00:55:46 +0000 (13 16:55 -0800) | ||
| tree | 72af09bc5dac22d6a160715691a40b24b341ce4c | treesnapshot (tar.gz zip) |
| parent | 5b89db0e84bef81f6aa324f8f22a9258ff873de3 | commitdiff |
ATM, Solos PCI ADSL2+: Don't deref NULL pointer if net_ratelimit() and alloc_skb() interact badly.
If alloc_skb() fails to allocate memory and returns NULL then we want to
return -ENOMEM from drivers/atm/solos-pci.c::popen() regardless of the
value of net_ratelimit(). The way the code is today, we may not return if
net_ratelimit() returns 0, then we'll proceed to pass a NULL pointer to
skb_put() which will blow up in our face.
This patch ensures that we always return -ENOMEM on alloc_skb() failure
and only let the dev_warn() be controlled by the value of net_ratelimit().
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
If alloc_skb() fails to allocate memory and returns NULL then we want to
return -ENOMEM from drivers/atm/solos-pci.c::popen() regardless of the
value of net_ratelimit(). The way the code is today, we may not return if
net_ratelimit() returns 0, then we'll proceed to pass a NULL pointer to
skb_put() which will blow up in our face.
This patch ensures that we always return -ENOMEM on alloc_skb() failure
and only let the dev_warn() be controlled by the value of net_ratelimit().
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/atm/solos-pci.c | diffblobblamehistory |