| commit | d83d282bcbf24ec8ddd4f0eb57f7ad302c431b8a | |
| author | David S. Miller <davem@davemloft.net> | |
| Mon, 11 Apr 2011 23:00:00 +0000 (11 16:00 -0700) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 12 Apr 2011 18:21:30 +0000 (12 11:21 -0700) | ||
| tree | d70019b7c94d333c84ce3610186c8cff23b635d2 | treesnapshot (tar.gz zip) |
| parent | f344c25dbab1a392ef7a7afc8ca061b3b7285423 | commitdiff |
s2io: Fix warnings due to -Wunused-but-set-variable.
Most of these are cases where we are trying to read back a register
after a write to ensure completion.
Simply pre-fixing the readl() or readq() with "(void)" is sufficient
because these are volatile operations and the compiler cannot eliminate
them just because no real assignment takes place.
The case of free_rxd_blk()'s assignments to "struct buffAdd *ba" is a
real spurious assignment as this variable is completely otherwise
unused.
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Jon Mason <jdmason@kudzu.us>
Most of these are cases where we are trying to read back a register
after a write to ensure completion.
Simply pre-fixing the readl() or readq() with "(void)" is sufficient
because these are volatile operations and the compiler cannot eliminate
them just because no real assignment takes place.
The case of free_rxd_blk()'s assignments to "struct buffAdd *ba" is a
real spurious assignment as this variable is completely otherwise
unused.
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Jon Mason <jdmason@kudzu.us>
| drivers/net/s2io.c | diffblobblamehistory | |
| drivers/net/s2io.h | diffblobblamehistory |