| commit | d707522d421d10bb56c5054812eb1f53a39a5c08 | |
| author | Henrique de Moraes Holschuh <hmh@hmh.eng.br> | |
| Sat, 27 Feb 2010 21:45:29 +0000 (27 18:45 -0300) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Mon, 15 Mar 2010 16:06:21 +0000 (15 09:06 -0700) | ||
| tree | ba7197c1602bffd9136fc93d3a3e2c60d7fc72e3 | treesnapshot (tar.gz zip) |
| parent | f4d574122bc35f8c90effac2e3a2af2889e9ba81 | commitdiff |
thinkpad-acpi: fix ALSA callback return status
commit 88cc83772a3c7756b9f2b4ba835545ad90a08409 upstream.
Clemens Ladisch reports that thinkpad-acpi improperly implements the
ALSA API, and always returns 0 for success for the "put" callbacks
while the API requires it to return "1" when the control value has
been changed in the hardware/firmware.
Rework the volume subdriver to be able to properly implement the ALSA
API. Based on a patch by Clemens Ladisch <clemens@ladisch.de>.
This fix is also needed on 2.6.33.
Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 88cc83772a3c7756b9f2b4ba835545ad90a08409 upstream.
Clemens Ladisch reports that thinkpad-acpi improperly implements the
ALSA API, and always returns 0 for success for the "put" callbacks
while the API requires it to return "1" when the control value has
been changed in the hardware/firmware.
Rework the volume subdriver to be able to properly implement the ALSA
API. Based on a patch by Clemens Ladisch <clemens@ladisch.de>.
This fix is also needed on 2.6.33.
Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/platform/x86/thinkpad_acpi.c | diffblobblamehistory |